Fix empty token auth bypass#331
Merged
MichaelZhao21 merged 4 commits intohackutd:masterfrom Apr 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an authentication bypass in the judge Bearer token middleware.
models.NewJudgeinitializesToken: "", so any judge inserted via CSV import or single-add (server/router/judge.go:64,:1088,server/funcs/csv.go:62) sits in Mongo withtoken: ""until they call/judge/login. The middlewarein
server/router/middleware.goonly checkslen(authHeader) < 7, so anAuthorization: Bearerheader (literal "Bearer" + one space) passes the format check, slices to an empty token, and
FindJudgeByToken(db, "")runsFindOne({"token": ""})— matching the first not-yet-logged-in judgeand authenticating the request as them.
Fix:
server/router/middleware.go: reject empty token after slicing theBearerprefix.server/database/judge.go: defense-in-depth —FindJudgeByTokenshort-circuits on empty token so anyfuture caller is safe.
Fixes #[Issue]
Type of Change
Delete options that do not apply:
Is this a breaking change?